Possible Ad Injection?

Discussion in 'Bug Reports' started by elementofchaos7, Dec 16, 2011.

  1. elementofchaos7

    elementofchaos7 A Pony Every Pony Should Know

    Joined:
    Jun 30, 2011
    Messages:
    572
    Bro hoofs Received:
    0
    Occupation:
    Insanity
    Location:
    home
    >sweet nightmares
    I'm confused...
     
  2. Grey Knightmare

    Grey Knightmare Founder (Retired)

    Cutie Mark:
    Joined:
    Mar 21, 2011
    Messages:
    2,575
    Bro hoofs Received:
    0
    Clicking the logo link in the 'New Everypony Spring' theme keeps redirecting me to some weird site called 'bubbling library' - it only seems to be that one theme - someone might want to check that out?
     
  3. mike406

    mike406 Moderator
    Community Moderator Tech Staff Veteran

    Cutie Mark:
    Joined:
    Nov 23, 2011
    Messages:
    4,855
    Bro hoofs Received:
    5
    Location:
    EP's basement
    Screenshot please, I don't get that behavior.
     
  4. Yamiookami

    Yamiookami EP's Resident Yami

    Cutie Mark:
    Joined:
    Feb 26, 2012
    Messages:
    8,549
    Bro hoofs Received:
    0
    Occupation:
    Pushing carts at a store...woo-hoo.
    Location:
    Georgia, USA
    Click on "New Everypony Spring" under the "Twilight Sparkle" theme, not the "Everypony Network Spring" theme.
     
  5. mike406

    mike406 Moderator
    Community Moderator Tech Staff Veteran

    Cutie Mark:
    Joined:
    Nov 23, 2011
    Messages:
    4,855
    Bro hoofs Received:
    5
    Location:
    EP's basement
    Um...yes I understand. I mean I am not replicating what is happening on that theme.
     
  6. Grey Knightmare

    Grey Knightmare Founder (Retired)

    Cutie Mark:
    Joined:
    Mar 21, 2011
    Messages:
    2,575
    Bro hoofs Received:
    0
  7. Yamiookami

    Yamiookami EP's Resident Yami

    Cutie Mark:
    Joined:
    Feb 26, 2012
    Messages:
    8,549
    Bro hoofs Received:
    0
    Occupation:
    Pushing carts at a store...woo-hoo.
    Location:
    Georgia, USA
  8. Grey Knightmare

    Grey Knightmare Founder (Retired)

    Cutie Mark:
    Joined:
    Mar 21, 2011
    Messages:
    2,575
    Bro hoofs Received:
    0
    Seems to happen on any link relating to /forums/ and forum.php - doesn't matter if you click the navbar link or the logo (it's worth noting that both are shown to link to their usual address), again only on that one theme.
     
  9. Saikyo

    Saikyo That One Dog
    Veteran

    Cutie Mark:
    Joined:
    Aug 12, 2011
    Messages:
    6,119
    Bro hoofs Received:
    40
    Gender:
    Female
    Occupation:
    Fighting Game Player
    Location:
    FurAffinity
    This is an issue. As soon as I got in there my antivirus software lit up like fireworks.
     
  10. mike406

    mike406 Moderator
    Community Moderator Tech Staff Veteran

    Cutie Mark:
    Joined:
    Nov 23, 2011
    Messages:
    4,855
    Bro hoofs Received:
    5
    Location:
    EP's basement
    Ah, okay. Sorry I wasn't looking at the correct Spring theme, I can't read apparently. ...I'm looking into it.

    - - Auto Merge - -

    Okay. I see what is happening. There is no cause for alarm, it's an externally hosted javascript file not resolving correctly anymore. I believe it to be something left over from an old plugin as it isn't present on any other theme. I've removed it for the time being.
     
    #10 mike406, Oct 27, 2013
    Last edited: Oct 27, 2013
  11. Grey Knightmare

    Grey Knightmare Founder (Retired)

    Cutie Mark:
    Joined:
    Mar 21, 2011
    Messages:
    2,575
    Bro hoofs Received:
    0
    I fail to see how including a non existing JavaScript file would cause a redirect (there might be slightly more to this). But good to know it's sorted, thanks mike.
     
  12. mike406

    mike406 Moderator
    Community Moderator Tech Staff Veteran

    Cutie Mark:
    Joined:
    Nov 23, 2011
    Messages:
    4,855
    Bro hoofs Received:
    5
    Location:
    EP's basement
    Sorry, when I said 'not resolving correctly anymore' what I meant was it wasn't the code it should have been. It was a legitimate script gone "rogue" or whatever. At one point this host was a legitimate source for this YUI extension below here:
    http://sourceforge.net/projects/bubbling/

    And here is the vb.org plugin that uses it: http://www.vbulletin.org/forum/showthread.php?t=233135

    The culprit script that was doing the odd redirect came from [noparse]http://js.bubbling-library.com/2.1/build/dispatcher/dispatcher-min.js[/noparse] with, no surprise a redirect.

    Code:
    var redir_url = 'http://js.bubbling-library.com/'; if (window != top) { top.location.href = redir_url; } else { window.location = redir_url; }
    Out of curiosity I took a look at the corresponding dispatcher-min.js from vb.org's plugin. Again, no surprise it's actual YUI functions, as it should be.

    So what I think happened is this host might have gotten compromised or they/someone changed it for some reason. I don't know, it doesn't really have anything to do with Everypony specifically aside from us linking to it, so I don't exactly care; but this is prime reason why one should always try to locally host their scripts whenever possible. Unless it's something direct from a provider like jQuery or Google where you know exactly what you're getting.



    tl;dr it's gone, I made sure it's gone. There is nothing more to this (on our part). No more worrying. And thank you for bringing this to attention.
     
    #12 mike406, Oct 28, 2013
    Last edited: Oct 28, 2013
  13. Grey Knightmare

    Grey Knightmare Founder (Retired)

    Cutie Mark:
    Joined:
    Mar 21, 2011
    Messages:
    2,575
    Bro hoofs Received:
    0
    [MENTION=1543]mike406[/MENTION]
    Thank you for sorting it! :derpe:
     

Share This Page