I'm only really familiar with the Disney animated version, so I guess that'd be my favorite by default.
Gotta go with the old Disney version. Although, Ever After wasn't bad either. Fun fact: There are actually 3 (or possibly more) versions of R&H's play. One from the 60s and one from the late 90s.
I'd have to say the 50's animated movie as well. Something about it just puts it ahead of everything else. Can't put a finger on 'it'.