Well, the OP didn't necessarily say 'pony' it just said favorite 'character'. Anyhoo, my favorite character (pony or otherwise) is Dashie. Although, AJ comes in a VERY close 2nd.
Applejack, because there are endless possibilities for making fun of her name though there are of course other reasons the Great and Powerful Trixie is up there; I love how she is a complete wreck and more flawed than not, yet strives to be something legendary. Her character could be argued as delusional or admirable depending on the interpretation.
Twilight. She's smart, patient, resourceful, has powerful magic, and she reminds me of Patchouli Knowledge.
I like Rarity and the Cutie Mark Crusaders as a collective, though I probably lean a bit more towards Sweetie Belle if I had to choose just one of them. Also, Shining Armor.
As far as the CMC goes, I used to think that same. (That adorable lil' squeak in her voice... :333) After Spoilerers, however, I'm finding myself leaning more towards Scoots... Anywho; My overall favourite is probably still Dashie.
Dude I'm right there with you. I loved Sleepless in Ponyville and after the Season 4 Spoilers I found myself wanting to be very protective of Scootaloo.
Very difficult choice for me since I can't even bring myself to choose a favorite Mane 6 character, let alone an all-time favorite. Let's just say that Twi, Dashie, Rarity, AJ, Pinkie, Big Mac and Sweetie Belle all have a very special place in my heart and thusly "share" my #1 spot. Kinda crowded, I know. If you had to twist my arm and make me whittle that brief list down to one, I'd probably go with Dashie...at the moment. My answer would most likely change upon multiple arm-twistings.
I agree with Ridley- Discord is best pony. Sorry, but Discord is awesome. Being that I was a fan of Q first and am a major Trekkie, Discord is so much fun. Plus, he reminds me so much of my best friend. I'd love to learn more about Discord in the show and his interactions with the characters is great. Plus, given the last episode he was in, I find that Discord often has a kernel of truth in the things he says. I think overall, Twilight could learn alot more from Discord than Celestia, but then again, I'm a big Discord fan, so I'm biased. I also love my OC, there is literally nothing I would change about her, except maybe her cutie mark, but most days I love it. She has alot of personality and is very smart, even though she takes stupid risks and that's why she's always getting injured.
Discord is my favorite character overall, but if we're talking about the Mane Six, I'd have to say Pinkie Pie.
